[Feat] 산별 등산 기록 목록 API - 정상 인근 트래킹 사진 2장 응답 추가#166
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이번 변경은 사용자의 등산 기록 목록 조회 시 제공되는 시각적 정보를 개선하기 위한 것입니다. 기존의 산 기본 이미지 대신, 사용자가 실제 트래킹 중 정상 인근에서 촬영한 사진을 우선적으로 노출하여 사용자 경험을 향상시켰습니다. 이를 위해 데이터베이스 쿼리 구조를 조정하고 DTO 및 관련 테스트 코드를 업데이트하였습니다. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the user's hiking mountain record response to return up to two tracking photos instead of a single mountain image. The repository query was updated to fetch the two closest tracking photos using a lateral join and spatial distance sorting. The review feedback recommends optimizing the query's performance by casting the spatial coordinates to geometry instead of geography in the ST_Distance function, which reduces computational overhead while maintaining sufficient accuracy for sorting.
1 participant
🧾 요약
/api/hiking-records/me/mountains응답의 이미지를 산 기본 이미지 대신, 트래킹 중 촬영한 사진 중 정상 좌표 기준 가장 가까운 2장으로 변경🔗 이슈
✨ 변경 내용
HikingRecordRepositorySQL — LATERAL JOIN + ROW_NUMBER 피벗으로tracking_photos→tracking_sessions경유, ST_Distance 기준 정상 인근 사진 2장 조회UserHikingMountainRecordProjection—getImageUrl()→getImageUrl1(),getImageUrl2()로 분리GetUserHikingMountainRecordResponse—imageUrl: String→imageUrls: List<String>(null/blank 필터링)GetUserHikingMountainRecordResponseTest— 정상 매핑, blank 필터링, 사진 없는 케이스 검증 추가✅ 확인